Fix undefined symbol when built with VST3 disabled. #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit cd5369c added some cleanup code to `libs/ardour/session.cc`, which drags in the type info symbol of VST3PluginInfo. When built with `--no-vst3`, the resulting binary dies at startup: ``` ld-elf.so.1: /usr/local/lib/ardour8/libardour.so.3: Undefined symbol "_ZTIN6ARDOUR14VST3PluginInfoE" ``` Make that code compile conditional on VST3_SUPPORT. Occurs on FreeBSD 14.0-RELEASE, clang 16.0.6, amd64.
|
Thanks. That was indeed an oversight! |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 30, 2024
Undefined symbol at runtime when building with default options Upstream PR: Ardour/ardour#883 PR: 277938 Reported by: phryk-ports@wzff.de Approved by: dev@submerge.ch (maintainer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit cd5369c added some cleanup code to
libs/ardour/session.cc, which drags in the type info symbol of VST3PluginInfo. When built with--no-vst3, the resulting binary dies at startup:Make that code compile conditional on VST3_SUPPORT. Occurs on FreeBSD 14.0-RELEASE, clang 16.0.6, amd64.
Making the include statement conditional is not strictly necessary to fix the undefined symbol, but may prevent similar problems in the future.
Original bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277938