Prevent long delay caused by overflow when repeat period < frame duration #1028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when the repeat period for
sendPulseDistanceWidthFromArray
orsendPulseDistanceWidth
happens to be shorter than the time it actually took to send a frame, the calculation for the delay overflows. This leads to an indefinite/very long delay, basically hanging the program "forever".This PR adds a guard to prevent this overflow. Rather than hanging, when the repeat period is shorter than the actual frame duration, the program will proceed immediately to the next repetition. This doesn't feel totally correct since it means the period will be wrong, but IMO it's a better and more forgiving result than the status quo.
NB: Calling these methods with such a short repetition period is probably a mistake (as it was in my case). Still, this fix might save some future users some trouble.