New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bang & Olufsen support #1030
Bang & Olufsen support #1030
Conversation
Thanks for the contribution, but there are some errors. |
I apparently made a last minute error |
Thank you very much for the contribution. maybe I will make a few adaptions to it next. |
Have you tested sending? |
Can you post the timings for one command as well as for one command followed by a repeat? |
I have tested sending. |
did you specify
So does it make sense to support 40 bits in an IR library?
When does this happen? |
When a command is is repeated the next AGC part immediately follows the previous stop space and the normal stop mark is omitted. B&O commands are normally not repeated, only the buttons which you normally hold repeats, e.g. volume. The start state needs to be inverted when the first bit is skipped. It currently works in the unit test but not with a real remote. |
I should measure what I got then. But I will not be able to do that for a few days. It looks like the initial state is still off in sendBangOlufsenRawDataLink but I cannot test that right now. |
Thank you very much for your quality assurance, I forgot to change sendBangOlufsenRawDataLink() too. 🥇 |
I have now tested IR send and datalink receive again, and measured the carrier frequency. Since it does work even over IR, I'm fairly certain it would work reliably if this signal was fed to the rear "Sensor" input though, which unlike most other extender inputs does take a modulated signal. |
Supports both IR and Datalink '86 protocols
Has been tested with a Beo4 remote and a Beomaster 5500
The way repeats without gaps are handled could perhaps have been done in a cleaner way without the extra dummy message but I couldn't figure out another way that didn't require modifications to other parts of the library.