Fix next/prev tag behaviour in documents with continuations #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
brettkail-wk
approved these changes
May 3, 2021
sagesmith-wf
approved these changes
May 3, 2021
derekgengenbacher-wf
approved these changes
May 5, 2021
|
QA +10 @Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug whereby the next/prev buttons would not work correctly when the currently selected item had continuations, and the selection would wrap to the beginning or end of the document.
The bug can be seen on any document with a tag containing continuations: select the tag, and then press the "next tag" button in the top right. Selection will move back to the first tag in the document, not the next tag.