Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent insertion of script tags if document already contains them #295

Merged

Conversation

paulwarren-wk
Copy link
Contributor

@paulwarren-wk paulwarren-wk commented Apr 10, 2022

If the viewer build was given a file that already contained an iXBRL viewer as input, it would add a second pair of <script> tags, leading to unpredictable results when the viewer was opened.

With this PR, the builder raises an error if given a viewer file as input.

Fixes #293

@aviary2-wf
Copy link

Security Insights

(1) Vulnerable direct dependencies were detected
  • 1 vulns in numpy < 1.21 via requirements.txt
  • Action Items


    Questions or Comments? Reach out on Slack: #support-infosec.

    @derekgengenbacher-wf
    Copy link
    Contributor

    QA +10 Unit and Skynet tests pass successfully. Builds successfully. Successfully verified this by running the viewer once on a document and then running it again and generating the error.

    @Workiva/release-management-p

    Copy link

    @rmconsole-wf rmconsole-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    +1 from RM

    @rmconsole4-wk rmconsole4-wk merged commit 6ac659c into Arelle:master Apr 11, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Does not cope gracefully with adding viewer data multiple times
    8 participants