#341 Fix: self closing tag serialization issue #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
sagesmith-wf
force-pushed
the
fix_self_closing_tag_issue
branch
from
66c1146
to
3cd6be9
Compare
derekgengenbacher-wf
approved these changes
Dec 2, 2022
aaroncameron-wk
approved these changes
Dec 2, 2022
allenbross-wf
approved these changes
Dec 2, 2022
brettkail-wk
approved these changes
Dec 2, 2022
|
QA +10 Unit and Skynet tests pass successfully. Builds successfully. Verified the this fixes the highlighting of the regions. @Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes the issue described by #341
Testing Steps:
Generate an ixbrl-vewer with and without this fix and verify this fixes the highlighting issues
Please Review
@Workiva/xt @paulwarren-wk @brettkail-wk