feat: moonyoungCHAE web server #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moonyoungCHAE <xpf_fl@naver.com>
GeunSam2
approved these changes
Aug 14, 2023
|
LGTM!! |
GeunSam2
reviewed
Aug 14, 2023
| FROM golang:alpine AS builder | ||
| WORKDIR /build | ||
| COPY . /build | ||
| RUN go mod download && go build -o main main.go |
There was a problem hiding this comment.
헉 제가 리뷰에서 빠트렸는데
모듈 다운로드랑 빌드 로직을 분리해서 캐시 히트율을 높이는 방법을 좀더 고민해 보시겠어요?
제가 실수로 머지를 해버렸는데, PR다시 올려주시면 감사하겠습니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10