Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create shmruin server. Fixes #5 #6

Merged
merged 1 commit into from
Aug 13, 2023
Merged

feat: create shmruin server. Fixes #5 #6

merged 1 commit into from
Aug 13, 2023

Conversation

shmruin
Copy link
Contributor

@shmruin shmruin commented Aug 8, 2023

Issue

Fixes #5

Modification

Add a simple flask server running on port 8080, and make a Dockerfile to build it.

Test

(On folder root of `shmruin)

docker build -t testimg .
docker run -d -p 8080:8080 testimg

localhost:8080
localhost:8080/api/v1/shmruin
localhost:8080/healthcheck

@shmruin shmruin requested a review from GeunSam2 as a code owner August 8, 2023 16:44
@shmruin
feat: create shmruin server. Fixes ArgoWorkflows-OSS#5
3331ff3 
Signed-off-by: shmruin <meme_hm@naver.com>
@GeunSam2
Copy link
Member

LGTM

@GeunSam2 GeunSam2 merged commit b5dcf7c into ArgoWorkflows-OSS:main Aug 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeunSam2 GeunSam2 GeunSam2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 송혜민의 서비스 컨테이너 이미지 제작
2 participants
@shmruin @GeunSam2