Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgId fix and websocket status on server #45

Closed

Conversation

abkulakli
Copy link
Contributor

@abkulakli abkulakli commented Apr 27, 2023

MessageId is generated always. This fixes if you want to set msgID. Please see the code block below.

Line 1147: node-red-contrib-ocpp/ocpp/ocpp-server.js

      if (msg.payload.MessageId) {
        msg.msgId = msg.payload.MessageId;
      }

      msg.payload = {};

Also documentation says MessageID. There is a typo there. I am not sure where to fix it.

@abkulakli
Copy link
Contributor Author

Added commit to send web socket connection status.

@abkulakli abkulakli changed the title msgId fix msgId fix and websocket status on server May 19, 2023
@bnystrom
Copy link
Collaborator

Thanks.
Changes edited into v1.3.5.

It was easier for me to add your changes to the modified upcoming code release.

@bnystrom bnystrom closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants