Refactor Diffstar code into new fitting_helpers module #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Create fitting_helpers sub-package to fit_smah_helpers.py and related code 2. Do we even need stars.py? 3. Created defaults.py to store parameter dictionaries
|
@alexalar this PR does not change the internals of any functions and their acceptance/treatment of bounded/unbounded parameters. But many things have been moved around, particularly into the new |
|
The notebook providing a demo of the fitter has in this PR been incorporated into the readthedocs, and so that migrated code should now be up-to-date with the reorganized diffstar. |
|
Closes #26 |
aphearin
added a commit
to LSSTDESC/lsstdesc-diffsky
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates some of the code previously used in fitting individual SFHs into a new sub-package fitting_helpers.