-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quick hotfix to have a default/fallback value for cardinal editor versioning #59
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 52.69% 52.53% -0.16%
==========================================
Files 9 9
Lines 668 670 +2
==========================================
Hits 352 352
- Misses 252 254 +2
Partials 64 64 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for quick fix.
for further fix, need to get release.Name from downloaded version, this will be more consistent for getting latest version name.
and also need to store version mapping somewhere (maybe in json file at cloud storage). so if there is cardinal editor update, we don't need to update world cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably better to just default to latest?
Overview
this is just a quick patch fix to a small bug. i opened a linear ticket to address this more thoroughly. https://linear.app/arguslabs/issue/WORLD-1046/cardinal-cardinal-editor-version-map-in-cli
Brief Changelog
Testing and Verifying