Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: world cardinal dev not exit on compilation error #63

Merged
merged 1 commit into from
May 2, 2024
Merged

fix: world cardinal dev not exit on compilation error #63

merged 1 commit into from
May 2, 2024

Commits on May 2, 2024

  1. fix: world cardinal dev not exit on compilation error (#63) 

    Closes: WORLD-1079

## Overview

Fix `world cardinal dev` is not exited when there is a compilation error, user don't need to send sigint/sigterm to exit the process.

## Brief Changelog

- add step to send signterm when `cmd.Exec` process is done / exited
- skip killing the `cmd.Exec` if process is already exited.

## Testing and Verifying

Manually tested by running `world cardinal dev`
    @zulkhair
    zulkhair committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0ea5303 View commit details
    Browse the repository at this point in the history