fix: prevent reporting elements with empty textContent

AriPerkkio · Jun 22, 2021 · 9f840da · 9f840da
1 parent a3bf775
commit 9f840da
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 4 deletions.
diff --git a/src/capture-announcements.ts b/src/capture-announcements.ts
@@ -33,7 +33,9 @@ export default function CaptureAnnouncements(options: Options): Restore {
     ) => {
         const content = trimWhiteSpace(textContent);
 
-        options.onCapture(content, politenessSetting);
+        if (content) {
+            options.onCapture(content, politenessSetting);
+        }
     };
 
     const onIncorrectStatusMessage: NonNullable<
@@ -42,7 +44,9 @@ export default function CaptureAnnouncements(options: Options): Restore {
         if (options.onIncorrectStatusMessage) {
             const content = trimWhiteSpace(textContent);
 
-            options.onIncorrectStatusMessage(content);
+            if (content) {
+                options.onIncorrectStatusMessage(content);
+            }
         }
     };
 
@@ -208,6 +212,7 @@ function onRemoveAttribute(
     }
 }
 
-function trimWhiteSpace(text: string) {
-    return text.trim().replace(WHITE_SPACE_REGEXP, ' ');
+function trimWhiteSpace(text: string): string | null {
+    const trimmed = text.trim().replace(WHITE_SPACE_REGEXP, ' ');
+    return trimmed.length > 0 ? trimmed : null;
 }
diff --git a/test/capture-announcements.test.ts b/test/capture-announcements.test.ts
@@ -322,4 +322,46 @@ describe('common', () => {
             'First message here Second message here'
         );
     });
+
+    test('onCapture should not report when textContent is empty', () => {
+        element.setAttribute('role', 'status');
+        appendToRoot(element);
+
+        element.textContent = ' ';
+        element.textContent = '    ';
+
+        // prettier-ignore
+        element.textContent = `
+                                
+                                
+                                
+        `;
+
+        expect(onCapture).not.toHaveBeenCalled();
+    });
+
+    test('onIncorrectStatusMessage should not report when textContent is empty', () => {
+        const element2 = document.createElement('div');
+        const element3 = document.createElement('div');
+
+        element.setAttribute('role', 'status');
+        element2.setAttribute('role', 'status');
+        element3.setAttribute('role', 'status');
+
+        element.textContent = ' ';
+        element2.textContent = '    ';
+
+        // prettier-ignore
+        element3.textContent = `
+                                
+                                
+                                
+        `;
+
+        appendToRoot(element);
+        appendToRoot(element2);
+        appendToRoot(element3);
+
+        expect(onIncorrectStatusMessage).not.toHaveBeenCalled();
+    });
 });