fix: detect element disappearance

AriPerkkio · Oct 22, 2021 · aa5c3cf · aa5c3cf
1 parent d814685
commit aa5c3cf
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/.storybook/stories/RoleStatus.stories.ts b/.storybook/stories/RoleStatus.stories.ts
@@ -126,3 +126,23 @@ export function PartOfContentChanges() {
         `
     );
 }
+
+addStoryName(AriaHiddenChanges, 'PASS');
+export function AriaHiddenChanges() {
+    return createMountToggle(
+        `
+        <div role="status">
+            <span aria-hidden="true">
+                Hello world
+            </span>
+        </div>
+        `,
+        `
+        <div role="status">
+            <span>
+                Hello world
+            </span>
+        </div>
+        `
+    );
+}
diff --git a/src/capture-announcements.ts b/src/capture-announcements.ts
@@ -60,7 +60,6 @@ export default function CaptureAnnouncements(options: Options): Restore {
     function updateAnnouncements(node: Node) {
         const element = getClosestElement(node);
         if (!element) return;
-        if (isHidden(element)) return;
 
         const liveRegion = getClosestLiveRegion(element);
 
@@ -71,6 +70,14 @@ export default function CaptureAnnouncements(options: Options): Restore {
                 const previousText = liveRegions.get(liveRegion);
                 const newText = getTextContent(liveRegion) || '';
 
+                // Update text content when element disappears inside live region
+                if (isHidden(element)) {
+                    if (previousText) {
+                        liveRegions.set(liveRegion, newText);
+                    }
+                    return;
+                }
+
                 if (previousText !== newText) {
                     onCapture(newText, politenessSetting);
                     liveRegions.set(liveRegion, newText);