fix(validator): resolve result parser properly

- Add missing brackets to comparison
AriPerkkio · Dec 28, 2020 · a4af9bb · a4af9bb
1 parent c4b071a
commit a4af9bb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/config/validator.ts b/lib/config/validator.ts
@@ -225,9 +225,8 @@ export function getConfigWithDefaults(config: ConfigWithOptionals): Config {
         cache: config.cache != null ? config.cache : DEFAULT_CACHE,
 
         resultParser:
-            config.resultParser || CI
-                ? DEFAULT_RESULT_PARSER_CI
-                : DEFAULT_RESULT_PARSER_CLI,
+            config.resultParser ||
+            (CI ? DEFAULT_RESULT_PARSER_CI : DEFAULT_RESULT_PARSER_CLI),
 
         concurrentTasks: config.concurrentTasks || DEFAULT_CONCURRENT_TASKS,
 

diff --git a/test/unit/config.test.ts b/test/unit/config.test.ts
@@ -67,6 +67,18 @@ describe('config', () => {
         expect(config.CI).toBe(process.env.CI === 'true');
     });
 
+    test('resultParser option is used when provided', () => {
+        mockConfig.mockReturnValue({
+            ...DEFAULT_CONFIGURATION,
+            CI: true,
+            resultParser: 'markdown',
+        });
+        const config = getConfig();
+
+        // Should use value from configuration, not default value resolved by CI flag
+        expect(config.resultParser).toBe('markdown');
+    });
+
     test('pathIgnorePattern is constructed into RegExp', () => {
         mockConfig.mockReturnValue({
             ...DEFAULT_CONFIGURATION,