fix: detect nodes added by replaceChild

AriPerkkio · Mar 27, 2021 · 45844af · 45844af
1 parent 178a7b6
commit 45844af
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/to-be-announced.ts b/src/to-be-announced.ts
@@ -174,6 +174,7 @@ export function register(
             interceptMethod(Element.prototype, 'removeAttribute', onRemoveAttribute),
             interceptMethod(Node.prototype, 'appendChild', onNodeMount),
             interceptMethod(Node.prototype, 'insertBefore', onNodeMount),
+            interceptMethod(Node.prototype, 'replaceChild', onNodeMount),
             interceptSetter(Node.prototype, 'textContent', onTextContentChange),
             interceptSetter(Node.prototype, 'nodeValue', onNodeValueChange)
         );

diff --git a/test/to-be-announced.dom.test.ts b/test/to-be-announced.dom.test.ts
@@ -150,5 +150,17 @@ ASSERTIVE_CASES.forEach(({ name, value }) => {
 
             expect('Hello world').toBeAnnounced();
         });
+
+        test('should announce when content is added with `replaceChild`', async () => {
+            const parent = document.createElement('div');
+            const oldChild = document.createElement('div');
+            parent.appendChild(oldChild);
+            appendToRoot(parent);
+
+            element.textContent = 'Hello world';
+            parent.replaceChild(element, oldChild);
+
+            expect('Hello world').toBeAnnounced();
+        });
     });
 });