Bug Fix: Error message is stripped if stack exists #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Could you check why the build fails? Also, let's add one or more test cases for this specific case. I'm reviewing this on mobile, but first glance tells me that the this code may not be able to handle multi line messages, but I'm not sure |
|
@AriaMinaei resolve test issues, add multiline test case |
|
Great! Allow me to test this on Thursday and publish to npm by then :) |
|
Published as RC |
|
@AriaMinaei I see the RC was published some time ago. Is this ready for a 2.2.0 release? |
|
Yeah this has been left unmerged for a long time. Sorry about that :) I just added a line in the readme asking people to try out the RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32