theatre/r3f: Support lines and points in snapshot view #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
❌ Deploy Preview for theatrejs-playground failed.
|
|
Thanks @donmccurdy! @AndrewPrifer seems like this can be incorporated into #139? |
|
@AriaMinaei Yeah, this is exactly the issue #139 was made for. I'll incorporate these types in the default schema too. |
|
Closing in favor of #139, which will incorporate support for points, lines, line loops, and line segments too in the default schema. |
|
Thank you @donmccurdy! |
|
Awesome, thanks! Will look over #139 soon. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glTF files may contain points, lines, line strips, and line loops in addition to triangle meshes. Userland code can register those types with the
editable(...)API, but the snapshot view will crash when these types are encountered. This PR attempts to fix that, so these types can be viewed and moved in the snapshot view.Test model:
primitive_modes.glb.zip
This contribution is funded by The New York Times.