Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Studio - mousewheel+shift on chrome windows always zooms out #19

Closed
RuiOrey opened this issue Sep 27, 2021 · 5 comments · Fixed by #30
Closed

Studio - mousewheel+shift on chrome windows always zooms out #19

RuiOrey opened this issue Sep 27, 2021 · 5 comments · Fixed by #30
Labels
bug good first issue help wanted

Comments

@RuiOrey
Copy link

RuiOrey commented Sep 27, 2021

Hi, thanks for the amazing library, it is being ultra useful.
I'm facing an issue:

  • using the mousewheel + shift on the studio timeline seems to always zoom out

Was able to circumvent this by @AriaMinaei advice of dragging the lower scrollbar to scale and for now is good to go for me.
But anyway here is the bug report.
Thanks!
@AriaMinaei
Copy link
Member

Thanks @RuiOrey. The behavior seems to be a bug with windows that I don't have the setup to reproduce right now.

If someone wants to contribute, the relevant line is here.

@jmyrland
Copy link
Contributor

I'm not able to reproduce this in chrome on windows.

shift+ scroll slides the sequence viewport from right to left (which I assume is the correct behaviour):
vSgMo4KN2K

However, the scrollbar on the bottom is not updated when shift + scroll-ing.

ctrl + scroll does work for zooming, but it is in my case a little "unpredictable":
CTDS008UT3

As you can see, each time I zoom in using scroll (to be clear; in the example above, I'm scrolling 1 tick forward), it zooms in way to far. Zooming out seems to be working fine though.

@RuiOrey
Copy link
Author

RuiOrey commented Sep 29, 2021

yes, sorry I was using ctrl +scroll, not shift + scroll.
yes that is what happens to me also using ctrl

@jmyrland
Copy link
Contributor

yes, sorry I was using ctrl +scroll, not shift + scroll.

No worries, I just wanted to clarify 👍

Is this just an issue in windows though? 🤔 I don't have another device to test on atm, but it sounds wierd to me that this is an OS specific issue.

@jmyrland jmyrland mentioned this issue Sep 29, 2021
Closed
jmyrland added a commit to jmyrland/theatre that referenced this issue Oct 2, 2021
@jmyrland
Improves scroll interaction for sequence editor
ea09f33 
- Scroll paning (`shift + scroll`) is now synced for the keyframe viewport, easing viewport and scrollbar (Closes theatre-js#22)
-  Scroll zooming out (`ctrl + scroll down`) is now bounded to avoid zooming out to infinity  (Closes theatre-js#19)

There is still some quirky behaviour when using scroll to zoom inwards. It does not seem to respect the `pivotPointInUnitSpace` correctly. I've tried fixing it, but I've hit a dead end.
@jmyrland jmyrland mentioned this issue Oct 2, 2021
Merged
@jmyrland
Copy link
Contributor

jmyrland commented Oct 2, 2021

I was not able to reproduce your issue (always zooming out), as I am able to zoom in and out using ctrl + scroll. But the zooming is a little bit "off", as it does not seem to respect the "pivot point" at which you are zooming. I've tried fixing it, but to no avail 😢

I have done one quality of life change (#30); when zooming outwards, it is now bounded to the sequence length. Previously, zooming outwards could be done "infinately", which causes some annoing issues. This is perticularly annoyng, as the "zoom-in" feature does not seem to respect the "pivot point". So to fix it, you have to manually drag the scrollbar:
uaLZqXZXKc

AriaMinaei pushed a commit that referenced this issue Oct 4, 2021
@jmyrland @AriaMinaei
Improves scroll interaction for sequence editor
bf0367b 
- Scroll paning (`shift + scroll`) is now synced for the keyframe viewport, easing viewport and scrollbar (Closes #22)
-  Scroll zooming out (`ctrl + scroll down`) is now bounded to avoid zooming out to infinity  (Closes #19)

There is still some quirky behaviour when using scroll to zoom inwards. It does not seem to respect the `pivotPointInUnitSpace` correctly. I've tried fixing it, but I've hit a dead end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improves scroll interaction for sequence editor jmyrland/theatre
3 participants
@RuiOrey @AriaMinaei @jmyrland