Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add how to install valgrind and clang-format on CONTRIBUTING.md #159

Closed
3 tasks done
ArielMAJ opened this issue May 14, 2023 · 7 comments · Fixed by #162
Closed
3 tasks done

Add how to install valgrind and clang-format on CONTRIBUTING.md #159

ArielMAJ opened this issue May 14, 2023 · 7 comments · Fixed by #162
Assignees
@PoulasthaMukherjee
Labels
GSSOC23 GirlScript Summer of Code 2023

Comments

@ArielMAJ
Copy link
Owner

ArielMAJ commented May 14, 2023 •
edited by tauanesales
Loading

  • Add it to "Local Development" section in CONTRIBUTING.md;
  • Remove how to install valgrind/clang-format from main README.
  • Explain that make valgrind and make format must always be run before commiting/making PRs
@PoulasthaMukherjee
Copy link
Contributor

Assign me this issue @ArielMAJ

@ArielMAJ
Copy link
Owner Author

Assign me this issue @ArielMAJ

Done

PoulasthaMukherjee pushed a commit to PoulasthaMukherjee/test.me that referenced this issue May 23, 2023
Update CONTRIBUTING.md ArielMAJ#159
76772b6 
- Added how to install valgrind and clang-format on CONTRIBUTING.md

- Explain that `make valgrind` and `make format` must always be run before commiting/making PRs
PoulasthaMukherjee pushed a commit to PoulasthaMukherjee/test.me that referenced this issue May 23, 2023
Merge pull request #2 from PoulasthaMukherjee/PoulasthaMukherjee-patc…
80b1459 
…h-1-#159-1

Update CONTRIBUTING.md ArielMAJ#159
PoulasthaMukherjee pushed a commit to PoulasthaMukherjee/test.me that referenced this issue May 23, 2023
Update README.md ArielMAJ#159
8b4b60f 
Removed how to install valgrind/clang-format from main README
@PoulasthaMukherjee
Copy link
Contributor

I have changed the markdown files. Can you merge my PR?

#162

@PoulasthaMukherjee
Copy link
Contributor

@ArielMAJ Also, could you add the gssoc23 label to this issue please? I'm a contributor.

@ArielMAJ
Copy link
Owner Author

I'll take a look at it once I have some free time

@tauanesales tauanesales added the GSSOC23 GirlScript Summer of Code 2023 label May 24, 2023
@ArielMAJ
Copy link
Owner Author

Label added. Lmk if we can help you with anything else.

@ArielMAJ ArielMAJ linked a pull request May 24, 2023 that will close this issue
Add how to install valgrind and clang-format on CONTRIBUTING.md #159 #162
Merged
ArielMAJ added a commit that referenced this issue May 24, 2023
@ArielMAJ @tauanesales
Merge pull request #162 from PoulasthaMukherjee/main
86d0e4d 
Add how to install valgrind and clang-format on CONTRIBUTING.md #159


Co-authored-by: tauanesales <taysales6@gmail.com>
@PoulasthaMukherjee
Copy link
Contributor

@ArielMAJ @tauanesales Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PoulasthaMukherjee PoulasthaMukherjee

Labels
GSSOC23 GirlScript Summer of Code 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add how to install valgrind and clang-format on CONTRIBUTING.md #159 PoulasthaMukherjee/test.me
3 participants
@tauanesales @ArielMAJ @PoulasthaMukherjee