Merge pull request #5 from Arimeka/fix-ffmpeg-streams-parsing

FIX: Empty streams in video/audio causes segmentation violation
Arimeka · Jan 31, 2020 · bfc4fab · bfc4fab
2 parents c815135 + b36df4d
commit bfc4fab
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/ffprobe.go b/ffprobe.go
@@ -26,6 +26,10 @@ func (info *Info) FFProbe() error {
 		}
 
 		codecCtx := stream.CodecCtx()
+		if codecCtx == nil {
+			// do nothing if can't extract codec from stream
+			continue
+		}
 		codec := codecCtx.Codec()
 
 		streamInfo := Stream{

diff --git a/ffprobe_test.go b/ffprobe_test.go
@@ -8,6 +8,7 @@ import (
 
 var bitrateFiles = map[string]int64{
 	"./fixtures/video.mp4":       551193,
+	"./fixtures/with-meta.mov":   481140,
 	"./fixtures/audio.mp3":       128000,
 	"./fixtures/not-a-video.mp4": 0,
 	"./fixtures/corrupted.mp4":   0,

diff --git a/fixtures/with-meta.mov b/fixtures/with-meta.mov