Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add-on lists: show add-on version" conflicts with http://bugzil.la/612168 #381

Closed
JustOff opened this issue Nov 21, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@JustOff
Copy link

commented Nov 21, 2017

When Add-on lists: show add-on version is enabled in Firefox 47-56, then changes introduced by bug 612168 are overwritten and restartless add-ons are never received the ADDON_UNINSTALL reason on uninstall, but ADDON_DISABLE (see bug 620541).

Here is test add-on: uninstall-test@Off.JustOff.xpi.zip

@Aris-t2

This comment has been minimized.

Copy link
Owner

commented Nov 21, 2017

I ran some tests on Firefox 56 and the add-on gets uninstalled identically with and without version number being active. The add-on does not get disabled when you uninstall it, so I have no idea what issue this might cause even, if it fires up the wrong reason. Extension page has to be reloaded/reopened for the add-on to disappear in both cases.

1

2

@JustOff

This comment has been minimized.

Copy link
Author

commented Nov 21, 2017

Please run test add-on attached above and you will see in console that when Add-on lists: show add-on version is on, then both Disable and Remove results to ADDON_DISABLE reason and never ADDON_UNINSTALL.

This is because CTR doesn't have these changes from bug 612168 in it's extensions.xml used for FF 47-56.

@Aris-t2

This comment has been minimized.

Copy link
Owner

commented Nov 21, 2017

OK, I found what is causing this and will offer a fix on next update.

This was no real problem anyway. Look into default xml files uninstall method from Fx56:

// If uninstalling does not require a restart and the type doesn't
// support undoing of restartless uninstalls, then we fake it by
// just disabling it it, and doing the real uninstall later.

@JustOff

This comment has been minimized.

Copy link
Author

commented Nov 21, 2017

OK, I found what is causing this and will offer a fix on next update.

Thank you!

This was no real problem anyway.

Actually it is a problem, because if an extension performs some cleanup on uninstall it will never be called, and that's how I found it.

@Aris-t2

This comment has been minimized.

Copy link
Owner

commented Nov 21, 2017

@JustOff

This comment has been minimized.

Copy link
Author

commented Nov 21, 2017

I confirm 1.7.3.2beta2 fixes the problem, tested with FF 52.5.0 ESR & Basilisk M1.

@Aris-t2 Aris-t2 closed this Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.