-
Notifications
You must be signed in to change notification settings - Fork 36
"Add-on lists: show add-on version" conflicts with http://bugzil.la/612168 #381
Comments
I ran some tests on Firefox 56 and the add-on gets uninstalled identically with and without version number being active. The add-on does not get disabled when you uninstall it, so I have no idea what issue this might cause even, if it fires up the wrong reason. Extension page has to be reloaded/reopened for the add-on to disappear in both cases. |
Please run test add-on attached above and you will see in console that when This is because CTR doesn't have these changes from bug 612168 in it's extensions.xml used for FF 47-56. |
OK, I found what is causing this and will offer a fix on next update. This was no real problem anyway. Look into default xml files uninstall method from Fx56:
|
Thank you!
Actually it is a problem, because if an extension performs some cleanup on uninstall it will never be called, and that's how I found it. |
I confirm 1.7.3.2beta2 fixes the problem, tested with FF 52.5.0 ESR & Basilisk M1. |
When
Add-on lists: show add-on version
is enabled in Firefox 47-56, then changes introduced by bug 612168 are overwritten and restartless add-ons are never received theADDON_UNINSTALL
reason on uninstall, butADDON_DISABLE
(see bug 620541).Here is test add-on: uninstall-test@Off.JustOff.xpi.zip
The text was updated successfully, but these errors were encountered: