Skip to content

Commit

Permalink
fix: disable grpc when readonly (#3105)
Browse files Browse the repository at this point in the history
  • Loading branch information
RogerHYang committed May 7, 2024
1 parent a7d0514 commit 71ceba9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/phoenix/server/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,13 @@ def _lifespan(
tracer_provider: Optional["TracerProvider"] = None,
enable_prometheus: bool = False,
clean_ups: Iterable[Callable[[], None]] = (),
read_only: bool = False,
) -> StatefulLifespan[Starlette]:
@contextlib.asynccontextmanager
async def lifespan(_: Starlette) -> AsyncIterator[Dict[str, Any]]:
async with bulk_inserter as (queue_span, queue_evaluation), GrpcServer(
queue_span,
disabled=read_only,
tracer_provider=tracer_provider,
enable_prometheus=enable_prometheus,
):
Expand Down Expand Up @@ -394,6 +396,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
prometheus_middlewares = []
app = Starlette(
lifespan=_lifespan(
read_only=read_only,
bulk_inserter=bulk_inserter,
tracer_provider=tracer_provider,
enable_prometheus=enable_prometheus,
Expand Down
4 changes: 4 additions & 0 deletions src/phoenix/server/grpc_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,17 @@ def __init__(
callback: Callable[[Span, ProjectName], Awaitable[None]],
tracer_provider: Optional["TracerProvider"] = None,
enable_prometheus: bool = False,
disabled: bool = False,
) -> None:
self._callback = callback
self._server: Optional[Server] = None
self._tracer_provider = tracer_provider
self._enable_prometheus = enable_prometheus
self._disabled = disabled

async def __aenter__(self) -> None:
if self._disabled:
return
interceptors: List[ServerInterceptor] = []
if self._enable_prometheus:
...
Expand Down

0 comments on commit 71ceba9

Please sign in to comment.