feat(datasets): download csv button #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mikeldking
commented
May 24, 2024
Comment on lines
+61
to
+62
| `/v1/datasets/download/csv/${dataset.id}`, | ||
| "_blank" |
There was a problem hiding this comment.
note this URL is non ideal. sould be /datasets/:dataset_id/csv
There was a problem hiding this comment.
cc @RogerHYang #3308
RogerHYang
approved these changes
May 28, 2024
mikeldking
added a commit
that referenced
this pull request
Jun 1, 2024
* feat(datasets): download csv button * cleanup
mikeldking
added a commit
that referenced
this pull request
Jun 6, 2024
* feat(datasets): download csv button * cleanup
mikeldking
added a commit
that referenced
this pull request
Jun 11, 2024
* feat(datasets): download csv button * cleanup
mikeldking
added a commit
that referenced
this pull request
Jun 17, 2024
* feat(datasets): download csv button * cleanup
This was referenced Jun 18, 2024
mikeldking
added a commit
that referenced
this pull request
Jun 29, 2024
* feat(datasets): download csv button * cleanup
mikeldking
added a commit
that referenced
this pull request
Jul 2, 2024
* feat(datasets): download csv button * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3307