This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
add unique indexes to votes / delegates #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
votesanddelegatesdo not contain unique indexes, meaning a bad restore can contain duplicate entries, affecting the forging order.The votes_uniq does allow multiple votes per transaction (although application logic would prevent this in Ark) in order for v1 bridgechains that have allowed more than one vote per transaction to continue functioning, while still providing protection against duplications.
To enforce a single vote per transaction, but at risk of breaking other chains, then the index should be changed to:
CREATE INDEX IF NOT EXISTS "votes_uniq" ON votes ("transactionId");