faustbrian
Follow
faustbrian
Follow
Achievements
Achievements
Highlights
Popular repositories
14,754 contributions in the last year
Less
More
Activity overview
Contributed to
PayvoHQ/sdk,
ArkEcosystemArchive/platform-sdk,
ArkEcosystem/explorer
and 5 other
repositories
Contribution activity
October 2021
Created 207 commits in 18 repositories
Created 7 repositories
- faustbrian/node-stdbundle JavaScript
- faustbrian/laravel-arbitrary-attributes PHP
- faustbrian/node-pm2 TypeScript
- faustbrian/node-hapi-rate-limiter-flexible TypeScript
- faustbrian/node-hapi-json-rpc TypeScript
- faustbrian/laravel-character-builder PHP
- faustbrian/faustbrian
Opened 22 pull requests in 7 repositories
PayvoHQ/sdk
8
merged
- fix(zil): bind zilliqa SDK instance to container
-
chore(dot): update
@polkadotdependencies - chore(btc): remove test imports from production files
- feat(btc): implement address validation
- feat(eth): implement address validation
- chore: add missing dependencies
- refactor(sdk): crash client if signed data is not present
-
refactor: revert
bip39Localeparameter
ArkEcosystem/laravel-foundation
5
merged
PayvoHQ/wallet
3
merged
PayvoHQ/profiles
2
merged
1
closed
faustbrian/node-sha1
1
open
PayvoHQ/json-rpc
1
merged
ArkEcosystem/docs
1
merged
Reviewed 78 pull requests in 11 repositories
PayvoHQ/wallet
38 pull requests
- chore: update SDK dependencies
- refactor: add tooltip to alias if it is truncated
- refactor: add tooltip to wallet card if alias is truncated
- fix: select dropdown issue with preset default value
- chore: update SDK dependencies
- fix: keep min required signatures on musig registration
- fix: adjust style of action column on pending and contact table
- fix: update new balance unless it is undefined
- feat: support plugin installation through url modal from monorepos
- fix: use all available networks for lookup
-
fix: fallback to avatar identicon when removing image in
CreateProfileform -
refactor: retrieve wallets by using
WalletRepository#findByAddressWithNetwork - fix: plugins show 0 bytes as size after installation
- refactor: add missing border in sign message modal
- refactor: properly retrieve a transactions sender
- chore: update typescript to v4.4.3
- fix: missing mnemonic field on sign message
- fix: handle type errors when filtering wallet pending transactions
-
fix: enable sorting by delegate in
AddressTable - refactor: check against bind network in vote special handling
- fix: showing delegate names over wallet names
- feat: add dropdown menu to wallet cards
- fix: remove coincap provider from settings
- fix: update setting of default fee value in transaction forms
- chore: use consistent names in profile import back buttons
- Some pull request reviews not shown.
ArkEcosystem/paper-wallet
10 pull requests
- chore(deps): bump url-parse from 1.5.1 to 1.5.3
- chore(deps): bump color-string from 1.5.3 to 1.6.0
- chore(deps): bump ws from 5.2.2 to 5.2.3
- chore(deps): bump dns-packet from 1.3.1 to 1.3.4
- chore(deps): bump browserslist from 4.12.0 to 4.16.6
- chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9
- chore(deps): bump url-parse from 1.4.7 to 1.5.1
- chore(deps): bump ssri from 6.0.1 to 6.0.2
- chore(deps): bump path-parse from 1.0.6 to 1.0.7
- chore(deps): bump tmpl from 1.0.4 to 1.0.5
ArkEcosystem/laravel-foundation
6 pull requests
ArkEcosystem/qrcode
6 pull requests
PayvoHQ/sdk
4 pull requests
ArkEcosystem/core-plugin-skeleton
4 pull requests
ArkEcosystem/docs
3 pull requests
ArkEcosystem/explorer
2 pull requests
ArkEcosystem/core
2 pull requests
ArkEcosystem/ledger-transport
2 pull requests
ArkEcosystem/core-manager
1 pull request
Created an issue in nunomaduro/larastan that received 3 comments
Extending eloquent builder to recognise scopes
Larastan Version: dev-master
--level used: 8
Pull request with failing test: n/a
Description
Since commit 88422fb it is possible to properly disc…
3
comments
Opened 27 other issues in 2 repositories
PayvoHQ/wallet
23
open
1
closed
- Remove unused component parameters
- Avoid object destructuring for single properties
- Compose large JSX blocks
- Resolve circular dependencies
- Explicitly import files
- Abstract shared error handling in transaction forms
- Avoid inverted conditionals
- Avoid use of truthy/falsey in tests
- Excessive use of boolean flags
- Review ledger implementation
- Remove warnings and unnecessary logs from tests
- Avoid switch statements to make the code more fluent and less nested
- Favour guard clauses / assertion functions over optional chaining
- Reduce API surface of components that handle data rendering
- Avoid magic numbers
- Break down large component internals into functions and use composition
- Enable jest/no-identical-title rule
- Avoid ternary operator
- Replace defaultProps with object defaults
- Lack of return types
- Excessive use of any type
- Enable jest/valid-expect rule
- Upgrade TypeScript to 4.3
- Resolve all act errors
PayvoHQ/sdk
3
open
273
contributions
in private repositories
Oct 1 – Oct 15