This repository has been archived by the owner on Mar 5, 2019. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spkjp
previously approved these changes
Dec 17, 2018
faustbrian
changed the title
[WIP] refactor: handle the typescript setup
[WIP][DO NOT MERGE] refactor: handle the typescript setup
Dec 17, 2018
faustbrian
dismissed
spkjp’s stale review
December 17, 2018 03:47
Still WIP with more changes coming
faustbrian
added
Type: Refactor
The pull request improves or enhances an existing implementation.
Type: Breaking Change
The issue or pull request documents or introduces a breaking change.
labels
Jan 4, 2019
faustbrian
changed the title
[WIP][DO NOT MERGE] refactor: handle the typescript setup
refactor: handle the typescript setup
Jan 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Type: Breaking Change
The issue or pull request documents or introduces a breaking change.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes to handle the new TypeScript setup that is required.
Types of changes
Checklist