Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate repo with AppVeyor #8

Closed
ciband opened this issue Oct 25, 2018 · 13 comments
Closed

Integrate repo with AppVeyor #8

ciband opened this issue Oct 25, 2018 · 13 comments
Assignees
Labels
Environment: Continuous Integration The issue or pull request affects the continuous integration environment.

Comments

@ciband
Copy link
Contributor

ciband commented Oct 25, 2018

Is your feature request related to a problem? Please describe.
Now that the repo is configured for AppVeyor, someone with admin rights needs to integrate the repo with the Appveyor service for ArkEcosystem.

Describe the solution you'd like
I would like this repo integrated with AppVeyor and have the AppVeyor CI system run on PRs.

Describe alternatives you've considered
There are other Windows CI systems out there like Azure, but AppVeyor seemed the simplest.

Additional context
The .appveyor.yml has been tested on my personal AppVeyor account before I submitted it so this should work first time.

@faustbrian
Copy link
Contributor

@air1one will you move this repository to CircleCI soon?

@sleepdefic1t
Copy link
Contributor

@air1one
Could you weigh in on this?

Which should we use for Windows builds?
Does CircleCI support this,
or do we need Appveyor?

@ciband
Copy link
Contributor Author

ciband commented Nov 20, 2018

To my knowledge, CircleCI does not support Windows. The other option for Windows CI is Azure. I think AppVeyor is simpler and the work is already done.

@faustbrian faustbrian added the Environment: Continuous Integration The issue or pull request affects the continuous integration environment. label Jan 4, 2019
@faustbrian
Copy link
Contributor

@sleepdefic1t do you need AppVeyor setup now or is it still only Linux you are working on at the moment?

@sleepdefic1t
Copy link
Contributor

@faustbrian Yes, please.
C++ Client & Crypto both could use Appveyor.
Current targets are Linux & macOS.

@faustbrian
Copy link
Contributor

@sleepdefic1t it's now enabled so you should be able to just create a config and it should pop up.

@ciband
Copy link
Contributor Author

ciband commented May 15, 2019 via email

@stale
Copy link

stale bot commented Jul 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale The pull request is in need of updates but there has not been a sufficient response. label Jul 22, 2019
@faustbrian
Copy link
Contributor

@sleepdefic1t the stale bot is following you. What's the status on this?

@ghost ghost removed the Status: Stale The pull request is in need of updates but there has not been a sufficient response. label Jul 22, 2019
@sleepdefic1t
Copy link
Contributor

@faustbrian
Mentioned it in ArkEcosystem/cpp-crypto/#20 already, but Appveyor needs some attention. Shows up in repo apps, and appveyor.yml is in place, but nada 🤷‍♂ .

@faustbrian
Copy link
Contributor

faustbrian commented Aug 30, 2019

@ciband
Copy link
Contributor Author

ciband commented Sep 3, 2019

This can be closed I think.

Like @sleepdefic1t said, curl is broken on Windows, which is a different issue than this.

I will open an issue for the curl problem.

@ghost
Copy link

ghost commented Sep 3, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Environment: Continuous Integration The issue or pull request affects the continuous integration environment.
Projects
None yet
Development

No branches or pull requests

3 participants