Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockchain): add missing paths test #106

Merged
merged 1 commit into from
Jul 16, 2019
Merged

test(blockchain): add missing paths test #106

merged 1 commit into from
Jul 16, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Should bring coverage back up to 100%

What kind of change does this PR introduce?

  • Tests

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

Should bring coverage back up to 100%
@ghost ghost added Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. labels Jul 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #106 into develop will increase coverage by 2.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #106     +/-   ##
========================================
+ Coverage     97.6%   100%   +2.4%     
========================================
  Files           15     15             
  Lines          250    250             
========================================
+ Hits           244    250      +6     
+ Misses           6      0      -6
Impacted Files Coverage Δ
src/api/paths.cpp 100% <0%> (+3.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad62ae7...a57ff37. Read the comment docs.

@faustbrian faustbrian merged commit f176b4a into ArkEcosystemArchive:develop Jul 16, 2019
@sleepdefic1t sleepdefic1t deleted the test(blockchain)/add-missing-paths-test branch August 7, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants