chore: improve API query usage. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API queries were previously limited to `limit` and `page`. This PR basically just changes the API query arguments to be accepted as a string. This PR changes the Query usage as well as the following: - updates all tests. - updates documentation to reflect changes. - updates changelog.
ghost
added
Complexity: High
Codecov Report
@@ Coverage Diff @@
## develop #114 +/- ##
======================================
Coverage 100% 100%
======================================
Files 15 15
Lines 249 249
======================================
Hits 249 249
Continue to review full report at Codecov.
|
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
|
Codacy not analyzing This PR is good to go otherwise, @faustbrian |
faustbrian
approved these changes
Aug 14, 2019
ghost
removed
the
Status: In Progress
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API queries were previously limited to
limitandpage.This PR basically just changes the API query arguments to be accepted as a string.
This PR also does the following:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
There will be several more updates before merge to master and a new version release.
The PR fulfills these requirements:
developbranch, not themasterbranch