Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add appveyor support #120

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@ciband
Copy link
Collaborator

commented Sep 1, 2019

Add appveyor support

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ciband ciband requested review from faustbrian, kristjank and supaiku0 as code owners Sep 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ciband

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 1, 2019

Builds failed with curl dependency error. I suspect the CI environment needs to be modified to handle this.

@sleepdefic1t
Copy link
Contributor

left a comment

@ciband
Building Curl is broken on Windows.
Let me know if it's something you'd like to tackle 👍

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 8901d14 into ArkEcosystem:develop Sep 3, 2019

7 of 8 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build-arduino-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.