Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing api endpoints #127

Merged
merged 7 commits into from
Sep 23, 2019
Merged

feat: add missing api endpoints #127

merged 7 commits into from
Sep 23, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 11, 2019

Adds the rounds API endpoints.

Adds the transaction/fees endpoint.

Adds the node/fees endpoint.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 11, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Sep 11, 2019
@sleepdefic1t
Copy link
Contributor

Thank you, @dated

Are there currently any more Endpoints that need added?
That way we can just roll it all into one PR instead of adding them individually.

@dated
Copy link
Contributor Author

dated commented Sep 12, 2019

I believe there's one more, node/fees.

@dated dated changed the title feat: add rounds api feat: add missing api endpoints Sep 13, 2019
@faustbrian
Copy link
Contributor

Any more endpoints missing that should be added? So we can wrap them up in a single PR.

@dated
Copy link
Contributor Author

dated commented Sep 13, 2019

The node/fees endpoint is missing.

@faustbrian
Copy link
Contributor

Will have a look once the node/fees endpoint is added.

@dated
Copy link
Contributor Author

dated commented Sep 16, 2019

@sleepdefic1t are you ok with the node/fees endpoint?

@sleepdefic1t
Copy link
Contributor

Looks good and all tests pass on macOS for me.
Thank you, @dated

@faustbrian
This is good to go 👍

@ghost
Copy link

ghost commented Sep 16, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 16, 2019
@dated
Copy link
Contributor Author

dated commented Sep 22, 2019

👀

@ghost
Copy link

ghost commented Sep 23, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit c1209c2 into ArkEcosystemArchive:develop Sep 23, 2019
@ghost
Copy link

ghost commented Sep 23, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@dated dated deleted the feat/rounds-api branch September 23, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants