Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup windows workflow #155

Closed
wants to merge 10 commits into from
Closed

ci: setup windows workflow #155

wants to merge 10 commits into from

Conversation

faustbrian
Copy link
Contributor

Summary

ArkEcosystemArchive/cpp-crypto#150

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #155 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files          26       26           
  Lines         497      497           
=======================================
  Hits          395      395           
  Misses        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcbadc...f7fb40d. Read the comment docs.

@sleepdefic1t
Copy link
Contributor

I dug a bit deeper, I think there's an issue with the tests.exe linking with libcurl.
May not even be related to workflows.

Copy link
Contributor

@ciband ciband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sleepdefic1t @faustbrian See my review comments for a possible solution.

@@ -110,4 +110,5 @@ jobs:
shell: cmd
run: msbuild "%GITHUB_WORKSPACE%\ark_cpp_client.sln"
- name: Test
shell: cmd
run: "%GITHUB_WORKSPACE%\\test\\Debug\\ark_cpp_client_tests.exe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded "Debug" string here should be replaced with the configuration build variable. I think that will fix the release CI issue.

@sleepdefic1t
Copy link
Contributor

Closing this for now.

I'm working on an alternative way to just use CURL as a system requirement in Desktop/Server.
(e.g. sudo apt-get install libcurl4-openssl-dev, brew install curl, choco install curl)

That will be a separate PR and should make Win CI easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants