-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup windows workflow #155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 79.47% 79.47%
=======================================
Files 26 26
Lines 497 497
=======================================
Hits 395 395
Misses 102 102 Continue to review full report at Codecov.
|
I dug a bit deeper, I think there's an issue with the tests.exe linking with libcurl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sleepdefic1t @faustbrian See my review comments for a possible solution.
@@ -110,4 +110,5 @@ jobs: | |||
shell: cmd | |||
run: msbuild "%GITHUB_WORKSPACE%\ark_cpp_client.sln" | |||
- name: Test | |||
shell: cmd | |||
run: "%GITHUB_WORKSPACE%\\test\\Debug\\ark_cpp_client_tests.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded "Debug" string here should be replaced with the configuration build variable. I think that will fix the release CI issue.
Closing this for now. I'm working on an alternative way to just use CURL as a system requirement in Desktop/Server. That will be a separate PR and should make Win CI easier. |
Summary
ArkEcosystemArchive/cpp-crypto#150
Checklist