New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: drop ark-node API (v1) support #34
refactor: drop ark-node API (v1) support #34
Conversation
• Drop V1 code and tests • Drop "TWO" naming convention • rename AbstractApi >> API::Abstract • rename ApiBase >> API::Base • update cmake_example's main.cpp • Update CMake, tests, and docs to reflect changes • Bump version to '1.0.0'
Codecov Report
@@ Coverage Diff @@
## develop #34 +/- ##
==========================================
Coverage ? 97.64%
==========================================
Files ? 29
Lines ? 851
Branches ? 0
==========================================
Hits ? 831
Misses ? 20
Partials ? 0
Continue to review full report at Codecov.
|
• Content-Type: application/json • API-Version: 2 • Accept: application/vnd.ark.core-api.v2+json
@ciband @sleepdefic1t conflicts |
• resolves merge conflicts in ArkEcosystem/Cpp-Client #34
RE: Conflicts extras/cmake_example/main.cpp
library.jsonResolved. test/api/two/two_votes.cppShould now be
Tests fail due to pending changes in Otherwise, this should be able to be merged. |
You should be able to rebase your branch locally on arkecosystem/cpp-client:master, resolve conflicts locally, commit the merge, then push to this PR branch. |
Proposed changes
per #30
covers updates at #32
• Drop V1 code and tests
• Drop "TWO" naming convention
• rename AbstractApi >> API::Abstract
• rename ApiBase >> API::Base
• Update CMake, tests, and docs to reflect changes
• update cmake_example's main.cpp
• Bump version to '1.0.0'
Types of changes
Checklist