Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: 1.2.0-arduino Release #81

Merged
merged 14 commits into from
Feb 17, 2019
Merged

misc: 1.2.0-arduino Release #81

merged 14 commits into from
Feb 17, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR is the 1.2.0-arduino release, and matches changes up to Cpp-Client 1.2.0 master.
reference: #79

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Feb 17, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 17, 2019 06:56
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. Complexity: Undetermined Needs specialized, in-depth review. Type: Maintenance The pull request updates dependencies or configuration files. labels Feb 17, 2019
@ghost
Copy link

ghost commented Feb 17, 2019

@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of f97ce602547c1a842ab54b9ef835dffecc16aaa2. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ghost
Copy link

ghost commented Feb 17, 2019

@sleepdefic1t The ci/circleci: build-linux-default job is failing as of f97ce602547c1a842ab54b9ef835dffecc16aaa2. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t sleepdefic1t changed the title misc: 1.2.0-arduino Release [WIP]misc: 1.2.0-arduino Release Feb 17, 2019
@sleepdefic1t
Copy link
Contributor Author

@faustbrian will push a few updates, and notify you when ready.

@sleepdefic1t sleepdefic1t changed the title [WIP]misc: 1.2.0-arduino Release misc: 1.2.0-arduino Release Feb 17, 2019
@sleepdefic1t
Copy link
Contributor Author

@faustbrian Ready to go 👍

@faustbrian faustbrian merged commit 94dd35f into ArkEcosystemArchive:arduino Feb 17, 2019
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Maintenance The pull request updates dependencies or configuration files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants