Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: API Empty TX Object Response #85

Merged
merged 11 commits into from May 8, 2019

Conversation

Projects
None yet
3 participants
@sleepdefic1t
Copy link
Contributor

commented May 7, 2019

Proposed changes

This small PR updates the API Response test when posting an empty transactions objects.
It also updates the changelog.

Response was:

"child "transactions" fails because ["transactions" must contain at least 1 items]"

Response is now:

"should NOT have fewer than 1 items"

It now tests for "statusCode" '422'

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 7, 2019

The ci/circleci: build-linux-default job is failing as of d61f66830daae5f5ae8e5e251f49e171f8206826. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 7, 2019

The ci/circleci: build-linux-default job is failing as of 0e21097b3214ebb3ffc67afacb6531634659e03b. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Test failures are not a result of this PR.

This is a PlatformIO/ArduinoJson package issue, and will be resolved like ArkEcosystem/cpp-crypto#76.

@faustbrian
Copy link
Contributor

left a comment

You should always test for a specific HTTP status code instead of relying on messages because those can always change. In this case you should test for status code 422 in the response.

use status code
- also update changelog brief
@sleepdefic1t

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Thank you, @faustbrian
PR has been updated accordingly 👍

@faustbrian faustbrian merged commit 6858d9b into ArkEcosystem:master May 8, 2019

5 of 6 checks passed

ci/circleci: build-linux-default Your tests failed on CircleCI
Details
ci/circleci: build-arduino-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details

@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:test/api-response branch May 9, 2019

@sleepdefic1t sleepdefic1t referenced this pull request May 10, 2019

Merged

test(chore): update ArduinoJson version #87

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.