Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(chore): update ArduinoJson version #87

Merged
merged 13 commits into from
May 10, 2019
Merged

test(chore): update ArduinoJson version #87

merged 13 commits into from
May 10, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR updates ArduinoJson v.5.13.2 >> v.6.10.1.

Specifically, this PR does the following:

  • updates ArduinoJson submodule.
  • updateds PIO.ini ArduinoJson flags (enforce v.6.10.1).
  • updates JSON use patterns in tests.
  • updates Wallets::Top test case.
  • adds ESP8266 & ESP32 WiFi option to test_main.cpp for IoT.
  • updates documentation with changes.

Types of changes

  • Build (changes that affect the build system)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

Further comments

This PR also resolves failing tests in #85 & #86

- this change also fixes the 'platformio_example' path
- update ArduinoJson v.5.13.2 >> v.6.10.1
- update ArduinoJson submodule.
- updated PIO.ini ArduinoJson flags (enforce v.6.10.1).
- update JSON use patterns in tests.
- update Wallets::Top test case.
- add ESP8266 & ESP32 WiFi option to test_main.cpp for IoT.
- update documentation with changes.
@ghost ghost added Complexity: High More than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. labels May 10, 2019
@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #87   +/-   ##
======================================
  Coverage    96.4%   96.4%           
======================================
  Files          14      14           
  Lines         250     250           
======================================
  Hits          241     241           
  Misses          9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735f820...4255ff0. Read the comment docs.

- update wallet::top test case.
- remove 'loop()' 'delay(x)'.
@faustbrian faustbrian merged commit ecda959 into ArkEcosystemArchive:master May 10, 2019
@sleepdefic1t sleepdefic1t mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants