refactor: signing #128
Merged
refactor: signing #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: High
Codecov Report
@@ Coverage Diff @@
## develop #128 +/- ##
===========================================
+ Coverage 91.4% 91.48% +0.07%
===========================================
Files 34 33 -1
Lines 873 881 +8
===========================================
+ Hits 798 806 +8
Misses 75 75
Continue to review full report at Codecov.
|
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
ghost
mentioned this pull request
faustbrian
previously approved these changes
Aug 14, 2019
|
@sleepdefic1t conflicts |
This PR decouples and improves the signing class. Specifically, this PR does the following: - adds `bcl` namespace to bcl lib. - moves all signing operation responsibilities to the `curve` class. - removes old crypto.cpp class and tests. - updates affected classes. - updates tests.
|
@faustbrian |
faustbrian
approved these changes
Aug 19, 2019
ghost
removed
the
Status: In Progress
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples and improves the signing class.
Specifically, this PR does the following:
bclnamespace to bcl lib.curveclass.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranch