This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
refactor: normalise ClientService#broadcast
response
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
729ae7d
to
067b5a3
Compare
3374ae7
to
cec0ecd
Compare
44ebf76
to
333bdc5
Compare
b1a0db9
to
53532ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 80.72% 78.62% -2.11%
==========================================
Files 26 26
Lines 664 725 +61
Branches 69 93 +24
==========================================
+ Hits 536 570 +34
- Misses 126 154 +28
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
fa7d524
to
4d321c3
Compare
09bba6f
to
a4fbaa9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a normalised structure for transaction broadcasting responses but the error handling still needs improving on a per coin basis due to how most coins return failures as plain text instead of using error or status codes.