Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: normalise ClientService#broadcast response #165

Merged
merged 12 commits into from
May 11, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented May 8, 2020

Resolves #126
Resolves #177

This introduces a normalised structure for transaction broadcasting responses but the error handling still needs improving on a per coin basis due to how most coins return failures as plain text instead of using error or status codes.

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #165 into master will decrease coverage by 2.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   80.72%   78.62%   -2.11%     
==========================================
  Files          26       26              
  Lines         664      725      +61     
  Branches       69       93      +24     
==========================================
+ Hits          536      570      +34     
- Misses        126      154      +28     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
src/dto/transaction.ts 67.85% <0.00%> (-28.58%) ⬇️
src/services/client.ts 72.29% <0.00%> (-1.83%) ⬇️
src/services/tracker.ts 81.42% <0.00%> (-1.43%) ⬇️
src/services/identity/utils.ts 100.00% <0.00%> (ø)
src/services/transaction.ts 59.20% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da6e466...a4fbaa9. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review May 11, 2020 06:53
@faustbrian faustbrian merged commit 32a8067 into master May 11, 2020
@faustbrian faustbrian deleted the normalise-broadcast branch May 11, 2020 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalise peer URLs Normalise ClientService#broadcast response
1 participant