This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
refactor(support): respect decimals for denominator in BigNumber#toHuman
#1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delaaxe
commented
Jun 1, 2021
delaaxe
changed the title
refactor(bignumber): use decimals in toHuman
refactor(bignumber): sacrifice decimals for humans
Jun 1, 2021
faustbrian
changed the title
refactor(bignumber): sacrifice decimals for humans
refactor(support): respect decimals for denominator in Jun 2, 2021
BigNumber#toHuman
faustbrian
reviewed
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please stick to descriptive commit messages, memes and fun have no place in commit history.
…cosystem/platform-sdk into refactor/bignumber-decimals
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
use decimals in BigNumber#toHuman
Checklist