Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(support): respect decimals for denominator in BigNumber#toHuman #1666

Merged
merged 55 commits into from Jun 3, 2021

Conversation

delaaxe
Copy link
Contributor

@delaaxe delaaxe commented Jun 1, 2021

Summary

use decimals in BigNumber#toHuman

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@delaaxe delaaxe changed the title refactor(bignumber): use decimals in toHuman refactor(bignumber): sacrifice decimals for humans Jun 1, 2021
@delaaxe delaaxe marked this pull request as draft June 1, 2021 17:09
@faustbrian faustbrian changed the title refactor(bignumber): sacrifice decimals for humans refactor(support): respect decimals for denominator in BigNumber#toHuman Jun 2, 2021
Copy link
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to descriptive commit messages, memes and fun have no place in commit history.

@delaaxe delaaxe marked this pull request as ready for review June 3, 2021 10:38
@faustbrian faustbrian merged commit d70f0e3 into master Jun 3, 2021
@faustbrian faustbrian deleted the refactor/bignumber-decimals branch June 3, 2021 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants