Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: rename passphrase to mnemonic #344

Closed
wants to merge 3 commits into from
Closed

Conversation

faustbrian
Copy link
Contributor

Resolves #340

Brian Faust added 2 commits May 25, 2020 07:14
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #344 into master will decrease coverage by 4.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   85.69%   81.61%   -4.09%     
==========================================
  Files          28       28              
  Lines         860      718     -142     
  Branches       94       57      -37     
==========================================
- Hits          737      586     -151     
- Misses        122      130       +8     
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/services/peer.ts 0.00% <0.00%> (-87.50%) ⬇️
src/services/transaction.ts 40.74% <0.00%> (-20.34%) ⬇️
src/services/fee.ts 78.57% <0.00%> (-17.86%) ⬇️
src/services/client.ts 80.13% <0.00%> (-8.35%) ⬇️
src/services/message.ts 90.47% <0.00%> (-5.18%) ⬇️
src/services/identity/keys.ts 84.00% <0.00%> (-4.00%) ⬇️
src/services/ledger.ts 91.66% <0.00%> (-0.34%) ⬇️
src/services/identity/wif.ts 100.00% <0.00%> (ø)
src/dto/transaction.ts 94.73% <0.00%> (+3.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b45733...cfdf526. Read the comment docs.

@faustbrian faustbrian closed this May 25, 2020
@faustbrian faustbrian deleted the fromMnemonic branch May 25, 2020 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename passphrase to mnemonic
1 participant