Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat: implement Address#validate #347

Merged
merged 3 commits into from
May 25, 2020
Merged

feat: implement Address#validate #347

merged 3 commits into from
May 25, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented May 25, 2020

Resolves #333

Brian Faust added 2 commits May 25, 2020 07:49
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #347 into master will decrease coverage by 11.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #347       +/-   ##
===========================================
- Coverage   85.69%   74.35%   -11.35%     
===========================================
  Files          28       25        -3     
  Lines         860      577      -283     
  Branches       94       54       -40     
===========================================
- Hits          737      429      -308     
- Misses        122      145       +23     
- Partials        1        3        +2     
Impacted Files Coverage Δ
src/services/fee.ts 0.00% <0.00%> (-96.43%) ⬇️
src/services/peer.ts 0.00% <0.00%> (-87.50%) ⬇️
src/dto/peer.ts 28.57% <0.00%> (-71.43%) ⬇️
src/services/transaction.ts 36.66% <0.00%> (-24.41%) ⬇️
src/services/identity/address.ts 86.20% <0.00%> (-10.23%) ⬇️
src/services/identity/public-key.ts 86.95% <0.00%> (-8.70%) ⬇️
src/services/client.ts 81.08% <0.00%> (-7.41%) ⬇️
src/services/identity/private-key.ts 85.71% <0.00%> (-7.15%) ⬇️
src/services/message.ts 90.47% <0.00%> (-5.18%) ⬇️
src/services/ledger.ts 87.23% <0.00%> (-4.77%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b45733...2851de6. Read the comment docs.

@faustbrian faustbrian merged commit 1196c9d into master May 25, 2020
@faustbrian faustbrian deleted the validate branch May 25, 2020 04:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement address validation
1 participant