Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: rename passphrase to mnemonic #383

Merged
merged 5 commits into from
Jun 3, 2020
Merged

refactor: rename passphrase to mnemonic #383

merged 5 commits into from
Jun 3, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jun 3, 2020

Resolves #340

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #383 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   75.55%   75.93%   +0.38%     
==========================================
  Files          57       59       +2     
  Lines        1448     1525      +77     
  Branches      131      143      +12     
==========================================
+ Hits         1094     1158      +64     
- Misses        352      365      +13     
  Partials        2        2              
Impacted Files Coverage Δ
src/services/identity/private-key.ts 88.23% <0.00%> (-4.63%) ⬇️
src/services/identity/keys.ts 88.00% <0.00%> (-3.31%) ⬇️
src/services/transaction.ts 46.97% <0.00%> (-0.32%) ⬇️
src/utils/crypto.ts 94.44% <0.00%> (ø)
src/utils/hash.ts 45.45% <0.00%> (ø)
src/services/identity/address.ts 86.04% <0.00%> (+0.33%) ⬆️
src/services/ledger.ts 96.42% <0.00%> (+0.59%) ⬆️
src/services/identity/public-key.ts 95.65% <0.00%> (+0.65%) ⬆️
src/services/message.ts 96.29% <0.00%> (+0.84%) ⬆️
src/dto/transaction.ts 84.00% <0.00%> (+2.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74b6dd...f3b9a2a. Read the comment docs.

@faustbrian faustbrian merged commit f7fc2aa into master Jun 3, 2020
@faustbrian faustbrian deleted the fromSeed branch June 3, 2020 04:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename passphrase to mnemonic
1 participant