Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat: validate ARK and NEO addresses to avoid collisions #405

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

Resolves #354

Brian Faust added 2 commits June 9, 2020 12:09
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #405 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   77.03%   77.16%   +0.13%     
==========================================
  Files          63       63              
  Lines        1576     1581       +5     
  Branches      141      144       +3     
==========================================
+ Hits         1214     1220       +6     
+ Misses        359      358       -1     
  Partials        3        3              
Impacted Files Coverage Δ
src/services/identity/address.ts 89.58% <0.00%> (+3.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f204f...c28c8b2. Read the comment docs.

@faustbrian faustbrian merged commit dd5540a into master Jun 9, 2020
@faustbrian faustbrian deleted the ark-neo branch June 9, 2020 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle ARK and NEO address collision
1 participant