Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

chore: update dependencies #414

Merged
merged 4 commits into from
Jun 19, 2020
Merged

chore: update dependencies #414

merged 4 commits into from
Jun 19, 2020

Conversation

faustbrian
Copy link
Contributor

No description provided.

Brian Faust added 2 commits June 13, 2020 07:32
@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #414 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   71.95%   71.92%   -0.03%     
==========================================
  Files          50       50              
  Lines         952      951       -1     
  Branches       67       67              
==========================================
- Hits          685      684       -1     
  Misses        242      242              
  Partials       25       25              
Flag Coverage Δ
#unit 71.92% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
packages/platform-sdk-support/src/bignumber.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2bb32c...dbeae2f. Read the comment docs.

@faustbrian
Copy link
Contributor Author

Ledger has an implicit dependency so that needs to be fixed before this can be merged.

@ledgerhq/hw-app-btc tried to access @ledgerhq/logs, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @ledgerhq/logs (via "@ledgerhq/logs")
Required by: @ledgerhq/hw-app-btc@npm:5.16.0 (via /home/runner/work/platform-sdk/platform-sdk/.yarn/cache/@ledgerhq-hw-app-btc-npm-5.16.0-40feab515a-2.zip/node_modules/@ledgerhq/hw-app-btc/lib/)

@faustbrian faustbrian marked this pull request as ready for review June 19, 2020 01:33
@faustbrian faustbrian merged commit b899a96 into master Jun 19, 2020
@faustbrian faustbrian deleted the deps branch June 19, 2020 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant