Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(profiles): use UUID as wallet identifier #423

Merged
merged 3 commits into from
Jun 15, 2020
Merged

refactor(profiles): use UUID as wallet identifier #423

merged 3 commits into from
Jun 15, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jun 15, 2020

Resolves #421

Brian Faust added 2 commits June 15, 2020 12:15
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #423 into master will increase coverage by 0.16%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   72.20%   72.36%   +0.16%     
==========================================
  Files          47       47              
  Lines         831      836       +5     
  Branches       49       49              
==========================================
+ Hits          600      605       +5     
  Misses        213      213              
  Partials       18       18              
Flag Coverage Δ
#unit 72.36% <92.30%> (+0.16%) ⬆️
Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/env.ts 86.04% <ø> (ø)
...sdk-profiles/src/repositories/wallet-repository.ts 84.61% <87.50%> (+0.83%) ⬆️
...dk-profiles/src/repositories/contact-repository.ts 96.42% <100.00%> (ø)
packages/platform-sdk-profiles/src/wallet.ts 90.47% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e78f95...0543b66. Read the comment docs.

@faustbrian faustbrian merged commit f59dbae into master Jun 15, 2020
@faustbrian faustbrian deleted the uuids branch June 15, 2020 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UUID for profiles, wallets and contacts
1 participant