Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat(intl): implement Currency#fromString to parse currency strings #438

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jun 17, 2020

Implements a way to parse currency strings to get the raw numbers from it. Requires to pass in a magnitude to limit the decimal numbers but defaults to 8 for the magnitude.

@faustbrian faustbrian force-pushed the intl-currency branch 2 times, most recently from 8a4bbc8 to cc5dc19 Compare June 17, 2020 04:01
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #438 into master will increase coverage by 4.88%.
The diff coverage is 71.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   66.66%   71.55%   +4.88%     
==========================================
  Files          45       49       +4     
  Lines         735      928     +193     
  Branches       46       65      +19     
==========================================
+ Hits          490      664     +174     
- Misses        228      240      +12     
- Partials       17       24       +7     
Flag Coverage Δ
#unit 71.55% <71.73%> (+4.88%) ⬆️
Impacted Files Coverage Δ
packages/platform-sdk-intl/src/currency.ts 71.73% <71.73%> (ø)
packages/platform-sdk-intl/src/datetime.ts 95.53% <0.00%> (ø)
packages/platform-sdk-intl/src/money.ts 96.15% <0.00%> (ø)
packages/platform-sdk-intl/src/numeral.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62979b0...0e37a6d. Read the comment docs.

@faustbrian faustbrian merged commit ed20a90 into master Jun 17, 2020
@faustbrian faustbrian deleted the intl-currency branch June 17, 2020 04:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant