This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
refactor: require ledger transport to be explicitly passed in #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the ledger transport is built isn't optimal to say the least because it executes things simply by requiring it which results in unwanted side-effects before you even use the library.
This PR changes the public API of the ledger services to require the transport to be explicitly passed in by consumers which will make it possible to require the transport only when it is needed and avoid any global side-effects.