Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: require ledger transport to be explicitly passed in #441

Merged
merged 3 commits into from Jun 17, 2020

Conversation

faustbrian
Copy link
Contributor

The way the ledger transport is built isn't optimal to say the least because it executes things simply by requiring it which results in unwanted side-effects before you even use the library.

This PR changes the public API of the ledger services to require the transport to be explicitly passed in by consumers which will make it possible to require the transport only when it is needed and avoid any global side-effects.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files          50       50           
  Lines         950      950           
  Branches       67       67           
=======================================
  Hits          684      684           
  Misses        241      241           
  Partials       25       25           
Flag Coverage Δ
#unit 72.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9f4b3...984f729. Read the comment docs.

@faustbrian faustbrian merged commit 56b38e8 into master Jun 17, 2020
@faustbrian faustbrian deleted the ledger-mess branch June 17, 2020 06:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant