Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(profiles): turn contact POJO into a class #447

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

Resolves #446

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #447 into master will increase coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   72.01%   72.61%   +0.60%     
==========================================
  Files          50       51       +1     
  Lines         954      975      +21     
  Branches       67       67              
==========================================
+ Hits          687      708      +21     
  Misses        242      242              
  Partials       25       25              
Flag Coverage Δ
#unit 72.61% <100.00%> (+0.60%) ⬆️
Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/profile.ts 96.96% <ø> (ø)
packages/platform-sdk-profiles/src/contact.ts 100.00% <100.00%> (ø)
...dk-profiles/src/repositories/contact-repository.ts 97.14% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e963a...634c1bd. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review June 19, 2020 05:53
@faustbrian faustbrian merged commit 661793a into master Jun 19, 2020
@faustbrian faustbrian deleted the contact-model branch June 19, 2020 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat contacts as a class instance like Profile and Wallet
1 participant