Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: use Coins.Config by reference #461

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

Resolves #458

Only peers will not be used by reference because some coins use WebSockets or require peers in several places which would lead to having to implement some kind of watchers to recreate all of those instances. In those cases, it is advised to simply recreate the whole coin instance to ensure that all previous instances are destroyed and won't interfere with the new one.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #461 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   72.40%   72.40%           
=======================================
  Files          52       52           
  Lines         993      993           
  Branches       70       70           
=======================================
  Hits          719      719           
  Misses        247      247           
  Partials       27       27           
Flag Coverage Δ
#unit 72.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826b85d...735f886. Read the comment docs.

@faustbrian faustbrian merged commit 1c385c3 into master Jun 22, 2020
@faustbrian faustbrian deleted the reference-config branch June 22, 2020 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CoinConfig by reference
1 participant